feat(frame-pacer): overhaul logic and render FPS limits and presets

[githubawn]

• Added 15 FPS to render presets and expanded logic presets (1 to 960 FPS). (15 is the minimum in skirmish, not 30)
• Implemented array-based preset snapping for logic FPS.
• Removed redundant logic speed scaling guards and safety asserts.
• Removed debug lock for lower logic rates, they are fun features.

This change was generated with AI assistance. All generated code has been reviewed, tested, and verified for functionality.

[greptile-apps]

Greptile Summary

This PR replaces the fixed-step (±5 FPS) logic for LogicTimeScaleFpsPreset with an array-based preset system (1–960 + uncapped) that also snaps to the current render FPS when it falls between presets, and adds 15 FPS to the render preset list. The changeLogicTimeScale callers in both game variants are simplified by removing the old remainder-ceiling arithmetic and deferring setLogicTimeScaleFps only to the enable path.

• New preset arrays: RenderFpsPreset gains a 15 FPS entry; LogicTimeScaleFpsPreset replaces linear stepping with {1, 5, 15, 30, 45, 60, 75, 90, 105, 120, 240, 480, 960, UncappedFpsValue}, allowing extreme slow-motion (1 FPS) and fast-forward (960 FPS) with a first-class "uncapped" sentinel that disables the timescale entirely.
• Snap-to-render behaviour: getNextFpsValue/getPrevFpsValue accept an optional snapValue (the render FPS cap) and select whichever candidate — preset or snap — lands closest to the current value, ensuring the render rate is always reachable as a natural stopping point.
• Simplified changeLogicTimeScale: The remainder-ceiling math is gone; setLogicTimeScaleFps is now called only when enabling, intentionally preserving the last active logic FPS in the pacer so that re-enabling timescale from outside this path resumes from a sensible value.

Confidence Score: 5/5

Safe to merge — the algorithm handles all edge cases (floor at 1, UncappedFpsValue ceiling, value equal to snap, values between presets) correctly, and both game-variant call sites are updated symmetrically.

All snap, floor, and ceiling paths through the new getNextFpsValue/getPrevFpsValue logic produce correct results. The UncappedFpsValue sentinel flows correctly through the clamping guard and the enable/disable decision in both CommandXlat.cpp files. No data is silently dropped or miscalculated in any tested scenario.

No files require special attention.

Important Files Changed

Filename	Overview
Core/GameEngine/Include/Common/FrameRateLimit.h	Removed the StepFpsValue/MinFpsValue enum from LogicTimeScaleFpsPreset, replaced with array-based design; added optional snapValue params to all three public methods; moved s_fpsValues to private — clean interface change with no issues.
Core/GameEngine/Source/Common/FrameRateLimit.cpp	Added 15 to RenderFpsPreset array, introduced LogicTimeScaleFpsPreset::s_fpsValues (1–960, UncappedFpsValue), replaced linear step logic with ascending-array search + snap; edge cases (floor at 1, ceiling at UncappedFpsValue, value==snapValue, value between presets) all handled correctly.
Generals/Code/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp	Simplified changeLogicTimeScale: removed the remainder-ceiling math, passes maxRenderFps as snapValue, and only calls setLogicTimeScaleFps when actually enabling timescale so the last active FPS is preserved for sane re-enable — logic is correct for all capped/uncapped combinations.
GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp	Identical simplification to the Generals/ counterpart; both files are kept in sync correctly.

_{Reviews (3): Last reviewed commit: "implemented feedback" | Re-trigger Greptile}

[xezon]

My review is incomplete.

This change conflicts a bit with a change I have in the works where logic step can run faster than render update. I can only continue it after the particle decoupling.

This change should wait.

[xezon]

15 is not ok when LOGICFRAMES_PER_SECOND is 30, because it will halve multiplayer game speed for everyone. That is what the static assert was for.

[xezon]

Can be simplified to = RenderFpsPreset::UncappedFpsValue