tweak(gui): Show Money Per Minute in Player Info List by L3-M · Pull Request #2738 · TheSuperHackers/GeneralsGameCode

L3-M · 2026-05-20T17:27:05Z

Relates To: feat(gui): Implement Player Info List #2136

This change show Money Per Minute in Player Info List for match Observers in Generals and Zero Hour.
It is only shown when ShowMoneyPerMinute = yes because some players may prefer the original Gentool replication or because the extra column takes additional space now.

greptile-apps · 2026-05-20T17:30:08Z

Greptile Summary

This PR adds a Money Per Minute column to the Player Info List HUD overlay visible to match observers in both Generals and Zero Hour. The new column is gated behind the existing ShowMoneyPerMinute setting to preserve the original Gentool layout for users who prefer it.

Adds LabelType_MoneyPerMinute / ValueType_MoneyPerMinute enum entries in both Generals and GeneralsMD header files, updating array sizes and label initialization accordingly.
Extends drawPlayerInfoList() in both game variants to read getCashPerMinute() from the player's Money object and format it via the existing formatIncomeValue() helper, while guarding layout and draw loops with showMoneyPerMinute checks so hidden columns don't consume screen space.

Confidence Score: 5/5

Safe to merge — the change is additive, gated by an existing feature flag, and re-uses the already-tested getCashPerMinute / formatIncomeValue path.

The new enum values correctly extend array sizes derived from LabelType_Count / ValueType_Count, so no out-of-bounds accesses are introduced. The skip guards in the layout and draw loops are symmetric, preventing hidden columns from affecting spacing. The Money Per Minute value is fetched and formatted through the same helpers already used elsewhere in the file. Changes are faithfully mirrored between Generals and GeneralsMD.

No files require special attention.

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Include/GameClient/InGameUI.h	Adds LabelType_MoneyPerMinute and ValueType_MoneyPerMinute enum values; LastValues array and display string arrays are correctly sized by LabelType_Count / ValueType_Count.
Generals/Code/GameEngine/Source/GameClient/InGameUI.cpp	Extends drawPlayerInfoList() to populate moneyPerMinuteValue via the existing getCashPerMinute() / formatIncomeValue() path; skip guards correctly prevent hidden column from affecting layout or draw.
GeneralsMD/Code/GameEngine/Include/GameClient/InGameUI.h	Mirror of the Generals header change — enum additions and array sizing are consistent.
GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp	Mirror of the Generals source change — identical logic for Zero Hour; no divergence from the Generals implementation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[drawPlayerInfoList called] --> B[Read showMoneyPerMinute flag]
    B --> C[Loop over player slots]
    C --> D[Get player Money object]
    D --> E[countMoney → moneyValue]
    D --> F[getCashPerMinute → moneyPerMinuteValue]
    E --> G[Build currentValues array team, money, moneyPerMinute, rank, xp]
    F --> G
    G --> H{column == ValueType_MoneyPerMinute?}
    H -- yes --> I[formatIncomeValue → formatted string]
    H -- no --> J[format as plain integer]
    I --> K[Update DisplayString and lastValues cache]
    J --> K
    K --> L[Measure maxValueWidths for all columns]
    L --> M[Label layout loop]
    M --> N{showMoneyPerMinute?}
    N -- no --> O[Skip MoneyPerMinute column]
    N -- yes --> P[Set columnLabelX, advance labelX]
    O --> Q[Draw loop per row]
    P --> Q
    Q --> R{showMoneyPerMinute?}
    R -- no --> S[Skip draw for MoneyPerMinute]
    R -- yes --> T[Draw label + value at columnLabelX]
    S --> U[Draw name column]
    T --> U

_{Reviews (2): Last reviewed commit: "tweak(gui): Show Money Per Minute in Pla..." | Re-trigger Greptile}

xezon · 2026-05-20T18:43:40Z

It would be nice if the $/min was more concise, but it is tricky. Chat Gippy brainstorms:

Some compact alternatives to $/min depending on the style you want:

$9999 +5555/m
$9999 (+5555)
$9999 ↑5555
$9999 · 5555/m
$9999 @5555/m
$9999 | +5555
$9999 ⟲5555
$9999 ⧖5555
$9999 ⌁5555/m

If this is for a game UI, these are common readable patterns:

$9999 (+5555) — very common in strategy/idler games
$9999 +5555/m — concise but explicit
$9999 ↑5555 — minimal and visually clean
$9999 5555/min — if the currency symbol already implies money

You could also abbreviate the unit:

/m = per minute
pm = per minute
m⁻¹ = more technical/scientific
⟂m / icons = stylized UI approach

For very compact HUDs:

$9.9k +5.5k
$9.9k ⬆5.5k
$9.9k (5.5k/m)

If you want, I can also suggest:

RTS-style UI variants
mobile-friendly variants
sci-fi/fantasy themed notation
ultra-minimal icon-based versions
typography/layout ideas for aligning the numbers cleanly

L3-M · 2026-05-20T20:13:12Z

Yeah. $/min is very long compared to other labels ( 5 characters vs 2 or 1 ) but on the other hand perhaps it is the clearest on what this value is.

I think +5500 is good.

githubawn · 2026-05-23T03:18:48Z

What about adding a header row? That would slightly save some screen space (or at least less repeating of information), which gives us one less reason to hide it behind a toggle option.

xezon · 2026-05-23T08:22:41Z

Header row would save horizontal space, but then the values would look pretty dense, and it may be more difficult to read.

Perhaps rename $/min to +, and use the same value formatting as on the Control Bar (+18k). That way the user can imply the meaning (+cash/min) more easily.

xezon · 2026-05-27T19:26:25Z

-				playerInfoListValue.format(L"%u", currentValues[column]);
+				if (column == PlayerInfoList::ValueType_MoneyPerMinute)
+				{
+					playerInfoListValue = formatIncomeValue(currentValues[column]);


if (!showMoneyPerMinute) continue

?

Because why set text when it is not shown?

xezon · 2026-05-27T19:27:57Z

 	Int labelX = baseX;
 	for (column = 0; column < PlayerInfoList::LabelType_Count; ++column)
 	{
+		if (!showMoneyPerMinute && column == PlayerInfoList::LabelType_MoneyPerMinute)


I suggest test the column first, because !showMoneyPerMinute can always be true and then it takes 2 tests often.

stephanmeesters · 2026-05-28T09:29:02Z

What about adding a header row? That would slightly save some screen space (or at least less repeating of information), which gives us one less reason to hide it behind a toggle option.

Something like: Team | Float | $/min | Rank | XP | Name

I’d agree, not only to reduce clutter but right now it’s not immediately clear that the first column is team (T0 means team zero which means FFA? Unclear) and it’s also not clear that * refers to generals rank. This stuff will be obvious to veterans of the game but not to new players.

xezon · 2026-05-28T09:42:03Z

Can you show mockup how it looks?

stephanmeesters · 2026-05-28T10:45:10Z

Perhaps something like this. Edit: The star (unicode) should actually be grey

Here's the PSD (I used Photopea)
generals-observer-mockup.zip

xezon · 2026-05-28T10:50:23Z

Aha so you want a header row in addition to the column cell prefixes.

Skyaero42 · 2026-05-29T09:49:26Z

Prefixes are not needed with header row - saves a few characters

also not needed with p/m (the value also cannot be negative as in some other RTS like Stellaris - so it is superfluous)

The light gray of the header is insufficient readable against the background.

xezon · 2026-05-30T09:16:48Z

My main ask for when you go with a header row is to make the separation of the columns clear.

Originally this was clear with the grey column value prefix characters.

I would leave the current iteration as is.

L3-M self-assigned this May 20, 2026

L3-M added Enhancement Is new feature or request GUI For graphical user interface Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels May 20, 2026

tweak(gui): Show Money Per Minute in Player Info List

41474dd

L3-M force-pushed the L3-M/money-obs branch from 93169dd to 41474dd Compare May 27, 2026 11:23

xezon reviewed May 27, 2026

View reviewed changes

Conversation

L3-M commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

xezon commented May 20, 2026

Uh oh!

L3-M commented May 20, 2026

Uh oh!

githubawn commented May 23, 2026

Uh oh!

xezon commented May 23, 2026

Uh oh!

xezon May 27, 2026

Choose a reason for hiding this comment

Uh oh!

L3-M May 28, 2026

Choose a reason for hiding this comment

Uh oh!

xezon May 28, 2026

Choose a reason for hiding this comment

Uh oh!

xezon May 27, 2026

Choose a reason for hiding this comment

Uh oh!

stephanmeesters commented May 28, 2026

Uh oh!

xezon commented May 28, 2026

Uh oh!

stephanmeesters commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xezon commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Skyaero42 commented May 29, 2026

Uh oh!

xezon commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

L3-M commented May 20, 2026 •

edited

Loading

greptile-apps Bot commented May 20, 2026 •

edited

Loading

stephanmeesters commented May 28, 2026 •

edited

Loading

xezon commented May 28, 2026 •

edited

Loading

xezon commented May 30, 2026 •

edited

Loading