refactor(metaevent): Split MetaEventTranslator::translateGameMessage() into smaller functions

[xezon]

• Follow up for fix(metaevent): Ignore order in which modifier keys are released to trigger meta events #2577

This change splits MetaEventTranslator::translateGameMessage() into smaller functions for better maintainability.

Logically it should function the same.

TODO

• Replicate in Generals

[greptile-apps]

Greptile Summary

This PR refactors MetaEventTranslator::translateGameMessage() by extracting its key-event and mouse-event handling into dedicated private helper methods (onMouseEvent, onKeyEvent, onKeyModStateRemoved, onKeyPressed, getActionKeyType, getKeyModState). The logic is equivalent to the original; the split improves readability and enables finer-grained unit testing.

• getActionKeyType and getKeyModState are extracted as static helpers, isolating the modifier-key classification and mod-state bit-packing from the main routing logic.
• onKeyModStateRemoved handles the modifier-key UP path (clearing tracked key+mod-state pairs and firing UP transitions), while onKeyPressed covers all other key-event routing including autorepeat suppression and the fast-forward replay hack.
• All new helpers are correctly scoped private, addressing the earlier review feedback.

Confidence Score: 5/5

Safe to merge — the change is a pure structural refactoring with no observable behavioral differences.

Every helper method is a direct extraction of the corresponding block from the original monolithic function. The routing conditions, loop structures, break placement, and state-mutation paths are all preserved. The previously raised concern about KEY_STATE_DOWN vs MSG_RAW_KEY_DOWN was confirmed acceptable by the developer and is consistent with how messages are constructed upstream. All new methods are correctly marked private.

No files require special attention.

Important Files Changed

Filename	Overview
GeneralsMD/Code/GameEngine/Include/GameClient/MetaEvent.h	Adds six private helper method declarations to MetaEventTranslator; correctly placed under a new private: section.
GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/MetaEvent.cpp	Implements the six new helper methods extracted from translateGameMessage(). Logic is semantically equivalent to the original; the refactoring improves cohesion without introducing new behavioral changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["translateGameMessage(msg)"] --> B{msg type?}
    B -->|RAW_KEY_DOWN / RAW_KEY_UP| C["onKeyEvent(msg, disp)"]
    B -->|RAW_MOUSE_*| D["onMouseEvent(msg)"]
    B -->|other| E[return KEEP_MESSAGE]

    C --> F["getActionKeyType(systemKey) → MappableKeyType"]
    C --> G["getKeyModState(systemKeyState) → MappableKeyModState"]
    C --> H{keyType == MK_NONE AND RAW_KEY_UP?}
    H -->|yes – modifier released| I["onKeyModStateRemoved(disp, keyModState)"]
    H -->|no – normal key event| J["onKeyPressed(disp, systemKeyState, keyType, keyModState)"]

    D --> K{Mouse message type}
    K -->|BUTTON_DOWN| L[Record mouseDownPosition]
    K -->|DOUBLE_CLICK| M[Set doubleClick flag]
    K -->|BUTTON_UP| N[Insert CLICK or DOUBLE_CLICK into stream]

Loading

_{Reviews (3): Last reviewed commit: "Refactor long conditions" | Re-trigger Greptile}

[RikuAnt]

Logically sound change. The focus is clearly to just relocate the code into new helper methods, but I would recommend some minor refactors as well.

[RikuAnt]

Extract condition and invert to eliminate unnecessary code block

const bool isAutorepeat = (systemKeyState & KEY_STATE_AUTOREPEAT) != 0;
if ( !isAutorepeat ) ...

[xezon]

It is a reasonable suggestions but I will leave it as is in this particular refactor because there is a reasoned comment and commented code in this branch.

[RikuAnt]

The comment could be moved before the inverted test to explain the autorepeat case. Also I would argue whether debug log is worthy commented code or not.

In any case, these are minor remarks so I'm fine if the code remains as is.

[RikuAnt]

Consider extracting this condition into a local variable (for example, "isMatchingKeyUp") to improve readability.

[xezon]

Fixed

[RikuAnt]

Consider extracting this condition into a local variable (for example, "isMatchingKeyPressReleaseEdge") to improve readability.

[xezon]

Fixed

[RikuAnt]

I don't have permission to resolve my own comments, so feel free to resolve them. Applies also for approval, so someone elses blessing is needed here. FYI @xezon