Skip to content

feat(ui5-comobobox, ui5-multi-combobox): add custom items#13640

Merged
Vonahz merged 23 commits into
mainfrom
combobox_custom_items
Jun 18, 2026
Merged

feat(ui5-comobobox, ui5-multi-combobox): add custom items#13640
Vonahz merged 23 commits into
mainfrom
combobox_custom_items

Conversation

@Vonahz

@Vonahz Vonahz commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

JIRA: BGSOFUIRILA-4141

Fixes: #11731

Introduces ui5-cbi-custom and ui5-mcbi-custom to enable custom content in ComboBox and MultiComboBox items.

@Vonahz Vonahz temporarily deployed to netlify-preview June 4, 2026 08:22 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Sample sync reminder

HTML sample changed but React sample (sample.tsx) not updated:

  • main/ComboBox/CustomItems
  • main/MultiComboBox/CustomItems

Please keep both samples in sync, or ignore if the change does not apply to both.

@sap-ui5-webcomponents-release

sap-ui5-webcomponents-release Bot commented Jun 4, 2026

Copy link
Copy Markdown

@Vonahz Vonahz temporarily deployed to netlify-preview June 4, 2026 09:00 — with GitHub Actions Inactive
@Vonahz Vonahz temporarily deployed to netlify-preview June 4, 2026 10:05 — with GitHub Actions Inactive
@Vonahz Vonahz temporarily deployed to netlify-preview June 4, 2026 10:10 — with GitHub Actions Inactive
@Vonahz Vonahz temporarily deployed to netlify-preview June 4, 2026 10:51 — with GitHub Actions Inactive
@Vonahz Vonahz requested a review from aleksandar-terziev June 4, 2026 11:01
@Vonahz Vonahz temporarily deployed to netlify-preview June 9, 2026 15:28 — with GitHub Actions Inactive
@Vonahz Vonahz temporarily deployed to netlify-preview June 9, 2026 15:40 — with GitHub Actions Inactive
@Vonahz Vonahz temporarily deployed to netlify-preview June 9, 2026 17:10 — with GitHub Actions Inactive
@Vonahz Vonahz requested review from nikoletavnv and nnaydenow June 10, 2026 10:53
Comment thread packages/main/src/MultiComboBoxItemCustom.ts Outdated
Comment thread packages/main/src/ComboBoxItemCustom.ts
@Vonahz Vonahz temporarily deployed to netlify-preview June 11, 2026 13:46 — with GitHub Actions Inactive
@Vonahz Vonahz temporarily deployed to netlify-preview June 11, 2026 13:55 — with GitHub Actions Inactive
@nikoletavnv

Copy link
Copy Markdown
Contributor

On mobile, the matching item does not have the selected blue state. For standard items and for desktop the item looks selected (blue background) when you start typing and the item is auto-completed, but for the combo-box custom item the selected style is missing on phone.

Screen.Recording.2026-06-15.124844.mp4

@Vonahz Vonahz requested a review from LilyanaOviPe June 15, 2026 12:35
Comment thread packages/website/docs/_samples/main/ComboBox/CustomItems/sample.html Outdated
Comment thread packages/website/docs/_samples/main/MultiComboBox/CustomItems/sample.html Outdated
@Vonahz Vonahz temporarily deployed to netlify-preview June 15, 2026 14:14 — with GitHub Actions Inactive
@Vonahz Vonahz temporarily deployed to netlify-preview June 15, 2026 14:27 — with GitHub Actions Inactive
@Vonahz Vonahz temporarily deployed to netlify-preview June 17, 2026 08:26 — with GitHub Actions Inactive
@Vonahz Vonahz temporarily deployed to netlify-preview June 17, 2026 08:27 — with GitHub Actions Inactive
Comment thread packages/main/src/ComboBoxItemCustom.ts Outdated
Comment thread packages/main/src/ComboBoxItemCustom.ts Outdated
Comment thread packages/main/src/ComboBoxItemCustom.ts Outdated
Comment thread packages/main/src/ComboBoxItemCustom.ts Outdated
Comment thread packages/main/src/MultiComboBoxItemCustom.ts Outdated
Comment thread packages/main/src/MultiComboBoxItemCustom.ts Outdated
Comment thread packages/main/src/MultiComboBoxItemCustom.ts Outdated
Comment thread packages/website/docs/_components_pages/main/ComboBox/ComboBox.mdx Outdated
nikoletavnv
nikoletavnv previously approved these changes Jun 17, 2026
@Vonahz Vonahz temporarily deployed to netlify-preview June 18, 2026 07:22 — with GitHub Actions Inactive
@Vonahz Vonahz temporarily deployed to netlify-preview June 18, 2026 12:35 — with GitHub Actions Inactive
@Vonahz Vonahz merged commit 4f37e60 into main Jun 18, 2026
42 of 46 checks passed
@Vonahz Vonahz deleted the combobox_custom_items branch June 18, 2026 13:52
@Vonahz Vonahz temporarily deployed to netlify-preview June 18, 2026 13:52 — with GitHub Actions Inactive
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

🧹 Preview deployment cleaned up: https://pr-13640--ui5-webcomponents.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]:Support for slot content in <ui5-cb-item> to enable custom rendering of combobox items

4 participants