Skip to content

Fix target_id when base_vws_url has a path prefix#3096

Merged
adamtheturtle merged 2 commits into
mainfrom
adamtheturtle/issue-3091-prefixed-target-id
Jul 17, 2026
Merged

Fix target_id when base_vws_url has a path prefix#3096
adamtheturtle merged 2 commits into
mainfrom
adamtheturtle/issue-3091-prefixed-target-id

Conversation

@adamtheturtle

Copy link
Copy Markdown
Member

Summary

  • Fixes UnknownTargetError, TargetStatusProcessingError, and TargetStatusNotSuccessError so .target_id is correct when base_vws_url includes a path prefix.
  • Centralizes parsing in a shared helper that finds the segment after targets, summary, or duplicates.

Closes #3091.

Test plan

  • Parametrized unit tests for all three exception classes with plain and prefixed URLs
  • Existing exception integration tests still pass
  • CI green on this PR

Made with Cursor

Parse the target ID from the path segment after targets, summary, or
duplicates so prefixed base URLs work. Closes #3091.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@adamtheturtle
adamtheturtle merged commit 0ecd993 into main Jul 17, 2026
16 checks passed
@adamtheturtle
adamtheturtle deleted the adamtheturtle/issue-3091-prefixed-target-id branch July 17, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Target exceptions report the wrong target_id with prefixed base URLs

1 participant