Shell-quote --env-var-format values - #1528
Merged
Merged
Conversation
Closes #1485 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1485.
--env-var-formatexists so its output can be fed toevalorsource, but it wroteKEY=valueraw. A database or license name containing a space produced a line the shell splits into an assignment plus a command; other metacharacters are worse.All three
--env-var-formatblocks —show-database-details,show-vumark-database-detailsandshow-license-details— now pass the value throughshlex.quote.Access keys and license keys are alphanumeric, so
shlex.quoteleaves them exactly as they were and existing output is unchanged. Only the name fields, which come from whatever the caller passed to--database-name/--license-name, can gain quotes.The existing
--env-var-formattests parse withline.split("=", 1)and still pass, since the values they see need no quoting. I have not added a test with a name that does need quoting: that would mean creating a real database with a space in its name against the shared CI account for one assertion.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM