Disconnect the cookie banner observer before replacing it - #1531
Merged
Conversation
Closes #1489 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1489.
_dismiss_cookie_bannerinstalled aMutationObserverondocument.documentElementand nothing ever disconnected it. It was guarded byif (!window.__otObserver), which meant a second observer was not installed on a document that already had one — but the guard also meant an existing observer was left running with no way to stop it, and the intent ("only one observer") was expressed as "never replace" rather than as "replace the old one".The observer now disconnects before being replaced. Since
window.__otObserverand the observer are both scoped to a document, a page load clears both together, so this changes nothing in the common case; it makes the single-observer invariant hold explicitly and gives the observer an actual disconnect._dismiss_cookie_banneris called on every navigation and fromwait_for_logged_in, so a session that stays on one page across many calls is where this matters.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM