Suppress only the expected errors from the retried dialog click - #1532
Merged
Conversation
Closes #1490 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1490.
_open_add_database_dialogclicks the add-database button, then clicks it a second time insidecontextlib.suppress(WebDriverException)because the dialog sometimes does not open on the first click.WebDriverExceptionis the base of the entire Selenium exception hierarchy, so that suppressed everything — a dead session, a browser crash, a chromedriver protocol error — and turned it into the 30 second timeout on the next wait, with no trace of the real cause.It now suppresses only the three errors that mean the first click did open the dialog: the button is covered by the dialog (
ElementClickInterceptedException), hidden (ElementNotInteractableException), or gone from the DOM (StaleElementReferenceException). Anything else propagates.I checked which one actually fires, against the real target manager — click the button, then click the same element again:
So the common path is
ElementClickInterceptedException, which is in the suppressed set, and the dialog is open afterwards as expected. The other two are kept for the variants where the portal hides or re-renders the button instead of covering it.WebDriverExceptionis no longer imported.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM