Reject an ambiguous license name when creating a cloud database - #1533
Merged
Conversation
Closes #1491 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1491.
create_cloud_databasewaited for any option in the license drop-down whose text matches, then calledselect_by_visible_text, which picks the first match. Vuforia does not stop you creating two licenses with the same name, and with two matches the database silently gets attached to whichever one the portal happens to list first — a wrong-but-plausible result that only shows up much later, as the wrong quota or an inactive database.The wait now collects the matching options rather than testing for any, and more than one match is a
ValueErrornaming the count and the license.The raise is marked
# pragma: no cover: covering it means creating two identically-named licenses on the shared CI account, which is a lot of real state to leave behind for one assertion.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM