Wait for the licenses search filter before clicking a row - #1535
Merged
Conversation
Closes #1493 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
The empty-table guard, the non-matching-row loop arc and the trailing ``return False`` were all unreachable in a live run, leaving the suite below the 100% coverage gate. Fold the empty check into the same condition as the match check, and look the row up by index rather than looping, so the only remaining defensive path is a single pragma. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tz9oY7GG92jssXJFUBDr5B
adamtheturtle
force-pushed
the
adamtheturtle/vws-web-tools-issue-1493
branch
from
August 27, 2026 08:05
7eaa133 to
cc4cf0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1493.
delete_licensewaits fortable_row_0_app_nameto be clickable — the unfiltered table — then types the license name into the search, presses ENTER, and immediately starts polling for an exactly-matching row. The filter is applied asynchronously, so the first poll can match a row in the table that is about to be replaced. On a delete, clicking the wrong thing matters more than elsewhere._click_license_rownow looks at all the license-name rows and requires every one of them to contain the search text before clicking the exact match, which is only true once the filter has been applied. That replaces the singlefind_elementwith an exact-match XPath, so this function no longer needs_xpath_literal.I measured this against the real portal. The licenses table filters quickly — it was down to the single matching row within 5 seconds, unlike the databases table in #1492, which took 10–15 seconds. So the window here is narrower, and the guard is correspondingly cheap: it is satisfied on an early poll rather than adding waiting.
Same change as #1492, for the licenses table.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM