Let callers pass their own Model Target CAD data URL - #1537
Merged
Conversation
Closes #1495 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
adamtheturtle
force-pushed
the
adamtheturtle/vws-web-tools-issue-1495
branch
from
August 27, 2026 06:22
cc45706 to
627eecc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1495.
The CAD data URL was a private constant baked into
get_model_target_web_api_details, so if it ever stops resolving, every consumer is stuck until this package makes a release.get_model_target_web_api_detailsnow takes acad_data_urlargument, and the default is public asMODEL_TARGET_WEB_API_CAD_DATA_URL.On the reported risk itself: pinning to a commit SHA is the right call and I have not changed it. A
raw.githubusercontent.comURL with a commit SHA does not depend on any branch, so moving or deleting a branch cannot 404 it — only renaming, deleting or rewriting the repository can, and no fallback URL protects against that either. What was missing was an escape hatch, which is what this adds. A tag or branch URL would trade a rare hard failure for a common silent one: the model changing under the tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM