Write show-* command output where the details are produced - #1540
Merged
Conversation
Closes #1498 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tz9oY7GG92jssXJFUBDr5B
adamtheturtle
force-pushed
the
adamtheturtle/vws-web-tools-issue-1498
branch
from
August 27, 2026 06:23
d682751 to
1a73e2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1498.
show-database-detailsscraped the details inside atry, quit the driver infinally, and only then formatted and wrote them — so the block that readsdetailssat outside the block that produces it, and the reader has to check for themselves that the success path is the only way to reach it.The formatting and the
click.echonow live in thetry, next to the scrape. Thefinallystill quits the driver, so the browser is still cleaned up if writing to stdout fails.I made the same move in
show-vumark-database-detailsandshow-license-details. They are the same shape, and fixing one of three would leave the file inconsistent for no reason.This is the same pattern as #1480 and #1481.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM