Return the license key the wait found - #1541
Merged
Merged
Conversation
Closes #1499 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1499.
get_license_detailswaited for the license key box to have non-empty stripped text, threw that value away, and then found the element and read.texta second time. Between the two reads the license page can re-render, and the second read is not guarded by anything — so the wait proves the key was there at one moment and the function returns whatever the box held at a later one, empty string included.It now returns the value the wait produced.
On the reported symptom: a whitespace-only key does not pass the wait.
" ".strip()is"", which is falsy, soWebDriverWait.untilkeeps polling and eventually raisesTimeoutException. The wayget_license_detailscan return an empty key is the second read, which is what this removes.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM