Use None, not an empty string, as the keep-waiting sentinel - #1543
Merged
Conversation
Closes #1501 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1501.
_database_id_in_urlreturned""to mean "not on a database page yet, keep polling" and a database ID otherwise, both typedstr. That overloads one type with two meanings, and it means an empty ID and no ID are the same value — so if the pattern ever could match an empty ID, the wait would poll for the full 180 seconds and then time out, with nothing to say why.It now returns
str | None.Noneis the sentinel, astris always an ID, and the two cases are distinguishable at the type level.To be accurate about the reported symptom: the pattern is
(?P<database_id>[^/]+), so it cannot match an empty ID today, and the infinite-wait case is not reachable. This makes it unreachable by construction rather than by a property of the regex that a reader has to go and check.The
Nonecheck after the wait is# pragma: no cover—WebDriverWait.untilonly returns a value it considers true, so it exists to narrow the type.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM