Say what a non-JSON credentials response actually contained - #1545
Merged
Conversation
Closes #1503 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1503.
Anything
response.json()cannot parse produced the same sentence: "The Vuforia credentials response had an unexpected shape." That reads as "the JSON was not the shape we expected", but it also fires for a200carrying an HTML sign-in page — the most likely real cause, since these calls authenticate with cookies scraped from the browser and an expired session gets an HTML redirect, not JSON. Somebody debugging that is told the wrong thing and has nothing to go on.The message now names the URL, the status code, the content type, and the first 500 characters of the body — the same excerpt length
_requestalready uses for HTTP errors.test_json_request_raises_runtime_error_for_invalid_jsonnow sends an HTML body and asserts the whole message.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM