Name the VuMark add-target dialog locators - #1546
Merged
Merged
Conversation
Closes #1504 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1504.
upload_vumark_templatehadinput[placeholder='Width']andinput[placeholder='Name']inline in its body. Matching on placeholder text means the upload breaks if the target manager relabels a field — and buried mid-function, there was nothing to tell a maintainer that these are the fragile part or where the rest of them are.The three locators are now named module constants with a comment saying why they match on placeholder text: the dialog gives these inputs no
idand noname, so there is nothing steadier to match on.I have deliberately not added fallback selectors. Guessing at
#widthorinput[name='width']without having seen the markup risks matching a different element on the page and silently uploading a template with the wrong width, which is worse than failing.The name input is now fetched through the same
presence_of_element_locatedwait as the other two, rather than a barefind_elementthat assumed the dialog had already rendered it.No user-facing behaviour change, so no newsfragment.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM