Open the target-key tab through one shared helper - #1547
Merged
Conversation
Closes #1505 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1505.
wait_for_vumark_target_linkandget_vumark_target_ideach defined their own_click_target_key_tabclosure, byte-for-byte identical apart from the wait they were handed. Both are inside aWebDriverWait.until, which is what makes "click the tab" read as "click the tab over and over".Both now call one
_open_target_key_tabhelper, whose docstring states what the wait is for.To be accurate about the reported symptom: the tab is not clicked on every poll.
_click_target_key_tabreturnsTrue, sountilreturns after the first click that goes through; the polling only covers the tab not being clickable yet, and the seconduntilinwait_for_vumark_target_link— the one that polls until the link appears — never touches the tab. The duplication is what made that need checking twice.No behaviour change, so no newsfragment.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM