Log in again when the shared test session has expired - #1548
Merged
Conversation
Closes #1506 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
adamtheturtle
force-pushed
the
adamtheturtle/vws-web-tools-issue-1506
branch
from
August 27, 2026 08:05
122381f to
05b9568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1506.
logged_in_chrome_driveris module-scoped: it logs in once and every test intest_create_database.pyshares that session. Nothing checks the session is still good. The module drives real Vuforia through a browser and takes tens of minutes on CI, so once it outlasts the session, every remaining test is driving a logged-out browser — and the symptom is aTimeoutExceptionwaiting for an element that was never going to appear, in whichever test happened to be running.A new autouse fixture loads a page that needs a session before each test and logs in again if the portal redirects to the login page. The check is one page load, so a healthy session costs a navigation per test rather than a login per test.
The re-login is marked
# pragma: no cover: it only runs when a session actually expires mid-module, which a healthy run never does, and--cov-fail-under 100coverstests/too.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM