Return the target ID from upload_vumark_template - #1549
Merged
Conversation
Closes #1486 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
adamtheturtle
force-pushed
the
adamtheturtle/vws-web-tools-issue-1486
branch
from
August 27, 2026 08:05
de92fca to
86d9292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1486.
upload_vumark_templatereturnedNone, so every caller that wanted the ID of what it had just uploaded had to name the target again and callwait_for_vumark_target_linkandget_vumark_target_iditself.vws-python-mock'sadmin/create_secrets_files.pydoes exactly that.It now returns the target ID, by composing those two functions rather than duplicating their waits.
This does make the function slower, and that is inherent to the request rather than a choice: the ID only exists once VWS has finished processing the target. Until then the target manager renders the name as plain text, with no link and no ID anywhere on the page. So "return the target ID" and "wait for processing" are the same thing, and the docstring's
Returns:says so.test_upload_vumark_templateasserts the returned ID is 32 alphanumeric characters, matching whattest_get_vumark_target_idalready asserts.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM