Drop a duplicated CLI invocation from test_create_databases_cli - #1550
Open
adamtheturtle wants to merge 1 commit into
Open
Drop a duplicated CLI invocation from test_create_databases_cli#1550adamtheturtle wants to merge 1 commit into
adamtheturtle wants to merge 1 commit into
Conversation
Closes #1507 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1507.
First, the premise: there is no documented Windows timeout.
grep -rn Windows tests src docsfinds nothing outside a trove classifier inpyproject.toml, andgit log -S Windows -- tests/finds no comment that was ever there and removed.test_create_databases_clialso passed onwindows-lateston both 3.12 and 3.13 in the last full CI run (2026-07-30). So I have not added a retry or a skip: there is no evidence of a Windows-specific failure to guard against, and an unconditional retry or skip on the one test that exercises the whole CLI end to end would hide real breakage.What is true is that this is the slowest test in the suite, which is what makes it the one most likely to run out of time. Every
runner.invokein it starts a fresh Chrome and logs in — it did that four times.Its first invocation was
show-license-detailsin YAML form againstcli_license_name, asserting the name and the key.test_show_license_details_clidoes exactly that, on the same fixture, with the same assertions, and also covers--env-var-format. So it was a full browser launch and login for assertions already made elsewhere. Removing it takes the test from four browser sessions to three, and the docstring now says why to think twice before adding a fourth.Nothing is lost from coverage:
show_license_detailsand both of its output formats stay covered bytest_show_license_details_cli.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM