wasm2c from binaryen conflicts with wasm2c from wabt #9002

Activity

1. kripken commented on Aug 13, 2026

   

   kripken

   on Aug 13, 2026

   Member

   More actions

   cc @lexi-nadia @tlively

   There is some ongoing debate about the future of these tools, so maybe this is moot or will be.

   But isn't the usual practice to rename on the distro side? (e.g. binaryen-wasm2c or byn-wasm2c for the fedora package)

   👍React with 👍1Reacted by Thomas Lively
2. rathann commented on Aug 13, 2026

   

   rathann

   on Aug 13, 2026

   ContributorAuthor

   More actions

   cc @lexi-nadia @tlively

   There is some ongoing debate about the future of these tools, so maybe this is moot or will be.

   Alright, thanks for your consideration.

   But isn't the usual practice to rename on the distro side? (e.g. binaryen-wasm2c or byn-wasm2c for the fedora package)

   It is and I'm going to do that. For now, I'm more concerned that at least one lit test fails on i686, but I'll open a separate issue for that.
3. robertkirkman commented on Aug 18, 2026

   

   robertkirkman

   on Aug 18, 2026

   Last edited by robertkirkman

   More actions

   sharing what I am doing, this is for people who are using the classically controversial command sudo make install or logical equivalents to or approximations of it, so that their wabt wasm2c does not get erased.

   --- a/src/tools/wasm2c/CMakeLists.txt
   +++ b/src/tools/wasm2c/CMakeLists.txt
   @@ -10,6 +10,6 @@ set(WASM2C_TEMPLATE_SOURCES
        ${PREBUILT_DIR}/wasm2c_spec_top.cpp
    )
    
   -binaryen_add_executable(wasm2c "wasm2c-builder.cpp;assertion-emitter.cpp;wasm2c.cpp;${WASM2C_TEMPLATE_SOURCES}")
   +binaryen_add_executable(binaryen-wasm2c "wasm2c-builder.cpp;assertion-emitter.cpp;wasm2c.cpp;${WASM2C_TEMPLATE_SOURCES}")
    # TODO: https://github.com/WebAssembly/binaryen/issues/8775 - stop using picosha2
   -target_include_directories(wasm2c PRIVATE ${PROJECT_SOURCE_DIR}/third_party/picosha2 ${PROJECT_SOURCE_DIR}/src/tools/wasm2c)
   +target_include_directories(binaryen-wasm2c PRIVATE ${PROJECT_SOURCE_DIR}/third_party/picosha2 ${PROJECT_SOURCE_DIR}/src/tools/wasm2c)
4. tlively commented on Aug 18, 2026

   

   tlively

   on Aug 18, 2026

   Member

   More actions

   Since Binaryen's wasm2c is still very much under construction, it might also make sense to make building it opt-in in the cmake config. I would be happy to accept a PR making that change.