ConstraintAnalysis: Add more simple inequalities - #8955
Merged
Conversation
tlively
reviewed
Jul 30, 2026
Comment on lines
+314
to
+315
| if (ac->type == bc->type && ac->type.isInteger() && | ||
| ac->add(Literal::makeFromInt32(1, ac->type)) == *bc) { |
Member
There was a problem hiding this comment.
We need to handle overflow here, right? IIRC, we don't consider x > UINT_MAX a contradiction, so we can end up with x > UINT_MAX || x >= 0. Then we would incorrectly turn this into x > UINT_MAX and misoptimize subsequent code.
Member
Author
There was a problem hiding this comment.
Good catch, I pulled this out of the next PR, which guards against overflow elsewhere, which made this invalid.
Fixed.
tlively
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the last pieces needed before the next PR, which will handle
loop overflows.