[wasm2c] Set the wasm-rt library as STATIC and EXCLUDE_FROM_ALL - #8958
Closed
lexi-nadia wants to merge 1 commit into
Closed
[wasm2c] Set the wasm-rt library as STATIC and EXCLUDE_FROM_ALL#8958lexi-nadia wants to merge 1 commit into
lexi-nadia wants to merge 1 commit into
Conversation
We don't actually need this to get built or used. The CMake rule exists only so that clang-tidy knows these files are C, not C++.
lexi-nadia
requested review from
stevenfontanella
and removed request for
a team
July 31, 2026 14:30
Member
|
Is it clang-tidy on the CI we're worried about or clang-tidy locally? If the former, then updating scripts/clang-tidy-diff.h would probably make more sense than using cmake. If the latter, idk. I guess most of the developers are not running clang-tidy locally. I'm actually not sure why telling CMake about these files would cause clang-tidy to treat them differently. Maybe clang-tidy is reading compile_commands.json? I see it has that capability if you pass |
tlively
approved these changes
Jul 31, 2026
tlively
left a comment
tlively
left a comment
Member
There was a problem hiding this comment.
LGTM anyway to unbreak the roller (hopefully)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't actually need this to get built or used. The CMake rule exists only so that clang-tidy knows these files are C, not C++.