Skip to content

[wasm2c] Only run clang-tidy-diff on files that are compiled #8959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lexi-nadia merged 1 commit into from
Jul 31, 2026
+1 −26
Merged

[wasm2c] Only run clang-tidy-diff on files that are compiled #8959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/clang-tidy-diff.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function realpath() {

CLANG_DIR=$(dirname $(dirname $(realpath $CLANG_TIDY)))
CLANG_TIDY_DIFF=$CLANG_DIR/share/clang/clang-tidy-diff.py
ARG="-quiet -p1 -iregex=src/.*\.(cpp|cc|c\+\+|cxx|c|cl|h|hpp|m|mm)"
ARG="-quiet -p1 -only-check-in-db -iregex=src/.*\.(cpp|cc|c\+\+|cxx|c|cl|h|hpp|m|mm)"
if [ ! -e "$CLANG_TIDY_DIFF" ]; then
echo "Failed to find clang-tidy-diff.py ($CLANG_TIDY_DIFF)"
exit 1
Expand Down
25 changes: 0 additions & 25 deletions src/tools/wasm2c/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
set(PREBUILT_DIR ${CMAKE_CURRENT_SOURCE_DIR}/prebuilt)
set(WASM_RT_DIR ${CMAKE_CURRENT_SOURCE_DIR}/wasm-rt)

set(WASM2C_TEMPLATE_SOURCES
${PREBUILT_DIR}/wasm2c_header_top.cpp
Expand All @@ -14,27 +13,3 @@ set(WASM2C_TEMPLATE_SOURCES
binaryen_add_executable(wasm2c "wasm2c-builder.cpp;assertion-emitter.cpp;wasm2c.cpp;${WASM2C_TEMPLATE_SOURCES}")
# TODO: https://github.com/WebAssembly/binaryen/issues/8775 - stop using picosha2
target_include_directories(wasm2c PRIVATE ${PROJECT_SOURCE_DIR}/third_party/picosha2 ${PROJECT_SOURCE_DIR}/src/tools/wasm2c)

set(WASM_RT_SOURCES
${WASM_RT_DIR}/wasm-rt-exceptions-impl.c
${WASM_RT_DIR}/wasm-rt-impl.c
${WASM_RT_DIR}/wasm-rt-mem-impl.c
)

set(WASM_RT_INCLUDES
${WASM_RT_DIR}/wasm-rt-exceptions.h
${WASM_RT_DIR}/wasm-rt.h
${WASM_RT_DIR}/wasm-rt-impl.h
${WASM_RT_DIR}/wasm-rt-impl-tableops.inc
${WASM_RT_DIR}/wasm-rt-mem-impl-helper.inc
)

set_source_files_properties(${WASM_RT_SOURCES}
PROPERTIES LANGUAGE C
)

set_source_files_properties(${WASM_RT_INCLUDES}
PROPERTIES LANGUAGE C
)

add_library(wasm-rt ${WASM_RT_SOURCES})
Loading