Skip to content

send STREAT-START event to downstream when app pushes data after sending EOS #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kkanag314 wants to merge 1 commit into
base: wpe-2.38
Choose a base branch
from
Open

send STREAT-START event to downstream when app pushes data after sending EOS #1719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,12 +598,19 @@ static void webKitMediaSrcLoop(void* userData)
} else if (GST_IS_EVENT(object.get())) {
// EOS events and other enqueued events are also sent unlocked so they can react to flushes if necessary.
GRefPtr<GstEvent> event = GRefPtr<GstEvent>(GST_EVENT(object.leakRef()));
bool isEOS = GST_EVENT_TYPE(event.get()) == GST_EVENT_EOS;

streamingMembers.unlockEarly();
GST_DEBUG_OBJECT(pad, "Pushing event downstream: %" GST_PTR_FORMAT, event.get());
bool eventHandled = gst_pad_push_event(pad, GRefPtr<GstEvent>(event).leakRef());
if (!eventHandled)
GST_DEBUG_OBJECT(pad, "Pushed event was not handled: %" GST_PTR_FORMAT, event.get());

if (isEOS) {
DataMutexLocker streamingMembersAfterEOS { stream->streamingMembersDataMutex };
GST_INFO_OBJECT(pad, "EOS pushed, resetting wasStreamStartSent to allow re-sending STREAM_START.");
streamingMembersAfterEOS->wasStreamStartSent = false;
}
} else
ASSERT_NOT_REACHED();
}
Expand Down