Skip to content

fix(ci): repair release eligibility GraphQL query - #67

Merged
avikalpg merged 1 commit into
mainfrom
nia/fix-release-eligibility-graphql-53
Sep 22, 2026
Merged

avikalpg merged 1 commit into
mainfrom
nia/fix-release-eligibility-graphql-53

Conversation

@nia-sg-bot

@nia-sg-bot nia-sg-bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • replace the malformed inline release-eligibility GraphQL query with a checked-in, readable GraphQL document
  • preserve all fail-closed pagination boundaries used by the eligibility classifier
  • add focused regression coverage for query structure and workflow wiring

Validation

  • python3 -m pytest -q tests/test_release_eligibility.py tests/test_release_eligibility_query.py — 9 passed
  • workflow YAML parse
  • Python compile checks
  • live GitHub GraphQL execution against the affected tested SHA
  • git diff --check

Scope

Fixes the current parser error before the CLI release-eligibility decision. This PR does not change labels, create tags/releases, or publish artifacts. The extension-side handoff is tracked separately in WildestAI/wildest-vscode-ext#51.

Fixes #53

Summary by CodeRabbit

  • Refactor

    • Moved release-eligibility query configuration into a dedicated file while preserving existing workflow behavior.
    • Continued retrieving associated pull requests, labels, and closing issues with pagination support.
  • Tests

    • Added validation to ensure the query is structurally valid, correctly connected to the release workflow, and checks all pagination boundaries.

Move the policy query into a readable GraphQL document so its structure is reviewable and the workflow can load it fail-closed.

Add focused coverage for delimiter balance, workflow wiring, and every pagination boundary used by the fail-closed classifier.
@nia-sg-bot nia-sg-bot added priority:P0 Critical path / blocks a usable product direction:aligned Aligned with the current WildestAI product direction roadmap Tracked on the public WildestAI roadmap north-star Directly advances the daily-driver north star labels Sep 22, 2026
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 90395dcb-1567-4044-b459-4c110e3e6cfb

📥 Commits

Reviewing files that changed from the base of the PR and between feba501 and 655f619.

📒 Files selected for processing (3)
  • .github/workflows/release-on-resolved-issue.yml
  • scripts/release_eligibility.graphql
  • tests/test_release_eligibility_query.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The release workflow now reads its GraphQL eligibility query from a dedicated file. New tests validate the query structure, workflow wiring, and pagination metadata.

Changes

Release eligibility query

Layer / File(s) Summary
Externalized eligibility query
scripts/release_eligibility.graphql, .github/workflows/release-on-resolved-issue.yml
The workflow reads the GraphQL query from scripts/release_eligibility.graphql. The query retains its existing repository, pull request, label, merge commit, and closing issue fields.
Query structure validation
tests/test_release_eligibility_query.py
Tests check balanced GraphQL delimiters, required query fields, workflow wiring, and four pageInfo and hasNextPage boundaries.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 655f6

The release workflow now loads its eligibility query from a checked-in file while preserving fail-closed pagination checks. No concrete merge-blocking issue is evidenced.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: repairing the release-eligibility GraphQL query used by CI.
Linked Issues check ✅ Passed Issue #53 coding requirements are satisfied. The workflow uses the checked-in GraphQL document, and the document requests all four bounded pageInfo values. The existing classifier enforces the same-re…
Out of Scope Changes check ✅ Passed The changed files support issue #53. The workflow change loads the release-eligibility query from a checked-in document. The new query and tests cover release workflow behavior. No product graph seman…
Full details: Docstring Coverage

Explanation

Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nia-sg-bot

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@avikalpg
avikalpg merged commit 5e36b20 into main Sep 22, 2026
4 checks passed
@avikalpg
avikalpg deleted the nia/fix-release-eligibility-graphql-53 branch September 22, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

direction:aligned Aligned with the current WildestAI product direction north-star Directly advances the daily-driver north star priority:P0 Critical path / blocks a usable product roadmap Tracked on the public WildestAI roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make immutable CLI release eligibility explicit and non-release merges green

2 participants