Skip to content

Connectors: Gate non-AI setting auto-registration#11564

Draft
jorgefilipecosta wants to merge 1 commit intoWordPress:trunkfrom
jorgefilipecosta:codex/connectors-auto-registration-gate
Draft

Connectors: Gate non-AI setting auto-registration#11564
jorgefilipecosta wants to merge 1 commit intoWordPress:trunkfrom
jorgefilipecosta:codex/connectors-auto-registration-gate

Conversation

@jorgefilipecosta
Copy link
Copy Markdown
Member

Summary

  • keep connector setting auto-registration unchanged for AI providers
  • only auto-register non-AI connector settings when plugin.is_active exists, is callable, and returns true
  • add focused PHPUnit coverage for the AI and non-AI registration paths

Testing

  • php -l src/wp-includes/connectors.php
  • php -l tests/phpunit/tests/connectors/wpRegisterDefaultConnectorSettings.php
  • vendor/bin/phpcs --standard=phpcs.xml.dist src/wp-includes/connectors.php tests/phpunit/tests/connectors/wpRegisterDefaultConnectorSettings.php
  • vendor/bin/phpunit tests/phpunit/tests/connectors/wpRegisterDefaultConnectorSettings.php (fails locally because the configured database host mysql is unavailable)

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant