oEmbed: Fix PHP warnings when a registered provider is malformed#11568
oEmbed: Fix PHP warnings when a registered provider is malformed#11568Sukhendu2002 wants to merge 3 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @tbradsha. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| if ( | ||
| ! is_array( $data ) || | ||
| count( $data ) < 2 || | ||
| ! array_key_exists( 0, $data ) || | ||
| ! array_key_exists( 1, $data ) | ||
| ) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I'll note that in Jetpack, we set index 1 to false if not set:
Automattic/jetpack/pull/48077
That matches the default param value:
https://developer.wordpress.org/reference/functions/wp_oembed_add_provider/
There was a problem hiding this comment.
Thanks for the review. Updated the validation to default $regex to false when index 1 is absent, matching the wp_oembed_add_provider() default behaviour. Also added a test to cover this case.
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/65068
Use of AI Tools
AI assistance: No
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.