Block Supports: Guard elements hover styles against a missing hover selector.#12312
Block Supports: Guard elements hover styles against a missing hover selector.#12312aaronrobertshaw wants to merge 1 commit into
Conversation
aaronrobertshaw
requested review from
andrewserong,
ramonjd,
talldan and
tellthemachines
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Only render `:hover` element styles for element types that actually define a hover selector. In `wp_render_elements_support_styles()`, only the `link` element type defines a `hover_selector`. If a block's `style.elements` carries a `:hover` object for `button` or `heading`, accessing `$element_config['hover_selector']` reaches for a key that does not exist, emitting an "Undefined array key 'hover_selector'" warning and passing an empty selector to the style engine. Add a `! empty( $element_config['hover_selector'] )` guard so hover processing is skipped for element types without a hover selector, and extend the elements styles test with a `button` `:hover` case that confirms only the base rule is emitted. Backport of Gutenberg PR WordPress/gutenberg#79511. Props aaronrobertshaw. See #65538.
aaronrobertshaw
force-pushed
the
fix/elements-hover-selector-guard
branch
from
b2eb9f6 to
780e2bc
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| ), | ||
| 'expected_styles' => '/^.wp-elements-\d+ .wp-element-button, .wp-elements-\d+ .wp-block-button__link' . $color_css_rules . '$/', | ||
| ), | ||
| 'button hover styles are skipped without a hover selector' => array( |
There was a problem hiding this comment.
Oh interesting. These tests are failing. What's that telling us about the state of trunk 🤔
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/65538
What?
Backports regression test added in Gutenberg PR WordPress/gutenberg#79511.
Core already has a fix protecting against undefined array index that WordPress/gutenberg#79511 addresses.
Why?
Protect against regressions around hover selectors for elements.
How?
Adds test for an element containing hover styles while not defining a hover CSS selector.
Testing Instructions
Tests_Block_Supports_WpRenderElementsSupportStylesshould pass.