Repository navigation
Update the dev tooling (abaplint 2.120.73, OpenUI5 1.153.0, playwright-core 1.64.0, express 5.3.0) - #6
Merged
Conversation
…t-core 1.64.0, express 5.3.0) The UI5 SPA leg gives the same result on OpenUI5 1.153.0 as on 1.144.0 against the abap2UI5 commit CI pins (76 pass, the one recorded deviation portable.box-details, 4 skips); RESULTS.md names the version. @abaplint/transpiler-cli stays on 2.13.93, the version @abap2ui5/node-runtime 1.146.0 records for its runtime - the conformance apps are transpiled against it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
…s fix
CI's frontend job checked out abap2UI5 5d7e91f (app/webapp as at
b812079, 1.146.0), where message box details stay empty on OpenUI5 >=
1.120, and test/frontend.test.mjs accepted portable.box-details failing.
abap2UI5 fixed it on main in 72c86cc; the job now pins main 1bbb9d4,
which carries it, and the known-fail list is empty - the documented
procedure ("unpin it once CI's abap2UI5 commit does"). A frontend that
loses the fix fails the test again. RESULTS.md, open question 7 and the
changelog say so; the UI5 SPA measures 77 pass, 0 fail, 4 skip.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the exact-pinned dev dependencies to their latest versions; the lockfile is regenerated by
npm install.Kept:
@abaplint/transpiler-cli2.13.93 (latest 2.14.3) - the conformance apps are transpiled against@abap2ui5/node-runtime1.146.0, whose runtime was built with 2.13.93 (abap2ui5.transpilerin its package.json); it moves with the next node-runtime release.conformance/hosts/cap2ui5/package.jsonis already on the latest versions (@sap/cds10.1.1,@cap-js/sqlite3.1.1,@cap2ui5/cds-plugin0.4.0), nothing to change there.conformance/RESULTS.md: the UI5 SPA row names OpenUI5 1.153.0; against the abap2UI5 commit CI pinned (5d7e91f) the result was the same as with 1.144.0 (76 pass,portable.box-details, 4 skips).Further commit - hold the UI5 SPA to every MUST: CI's frontend job pinned abap2UI5
5d7e91f(1.146.0'sapp/webapp), andtest/frontend.test.mjsacceptedportable.box-detailsfailing. abap2UI5 fixed it on main in72c86cc; the job now pins main1bbb9d4, and the known-fail list is empty - the procedure the test itself names ("unpin it once CI's abap2UI5 commit does"). RESULTS.md (77 pass, 0 fail, 4 skip, conformant), open question 7 and the changelog follow.Checked locally:
npm test(84/84, the UI5 SPA in Chromium against abap2UI51bbb9d4included),npm run lint:abap(0 issues),npm run generate(no diff).🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt