Skip to content

Fix #101 - #167

Closed
mercael91 wants to merge 4 commits into
abhiksark:devfrom
mercael91:fix/issue-101
Closed

Fix #101#167
mercael91 wants to merge 4 commits into
abhiksark:devfrom
mercael91:fix/issue-101

Conversation

@mercael91

@mercael91 mercael91 commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Closes #101. Add assertion messages to JSON checks and keep lines within 80 chars. Touches: checks/json/json1.py, checks/json/json2.py, checks/json/json3.py, tests/test_json_checks_messages.py.

@mercael91
Add assertion messages to JSON checks and keep lines within 80 chars
4cb45c4 
Signed-off-by: mercael91 <mercael91@gmail.com>
@mercael91
Add assertion messages to JSON checks and keep lines within 80 chars
b5c2cfb 
Signed-off-by: mercael91 <mercael91@gmail.com>
@mercael91
Add assertion messages to JSON checks and keep lines within 80 chars
f385f0a 
Signed-off-by: mercael91 <mercael91@gmail.com>
@mercael91
Add assertion messages to JSON checks and keep lines within 80 chars
89171af 
Signed-off-by: mercael91 <mercael91@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 87f28a84-78f3-4c69-b0c6-80650f67f066

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

abhiksark added a commit that referenced this pull request Nov 4, 2026
@abhiksark @mercael91
fix(curriculum): complete datetime and JSON assertion messages
c93566e 
Build on #168 and #167 to cover all six files in each issue, including the
previously omitted checks. State concrete expected values and preserve
assertion predicates, ordering, side effects, and success output.

Extend coverage to the full batches and verify useful JSON failure output.
Refs #103 and #101.

Co-authored-by: mercael91 <mercael91@gmail.com>
@abhiksark

abhiksark commented Nov 4, 2026

Copy link
Copy Markdown
Owner

The changes from this PR are incorporated into dev in c93566e, with co-author credit preserved. The follow-up completes json4.py through json6.py and states the concrete expected values in the json1.py and json2.py messages, covering all seven assertions required by #101.

Validation on the resulting dev tree: python -m pytest -q (238 passed), passing-curriculum verification, isolated source/wheel build, and installed-wheel checks passed. All six affected reference solutions pass; representative wrong answers fail with useful messages, and predicates and success output are unchanged. Hosted CI passed.

Closing this PR as incorporated. Thank you for the contribution.

@abhiksark abhiksark closed this Nov 4, 2026
@mercael91

mercael91 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Understood, thanks for reviewing! I'll keep this feedback in mind for future contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mercael91 @abhiksark