Skip to content

Add required phrases to lgpl-3.0_16.RULE #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eljees wants to merge 2 commits into
base: develop
Choose a base branch
from
+31 −3
Open

Add required phrases to lgpl-3.0_16.RULE #5251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
226d6cd
Add required phrases to lgpl-3.0_16.RULE
Eljees Jul 28, 2026
bf999f7
test: add regression test for lgpl-3.0_16 required phrases
Eljees Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/licensedcode/data/rules/lgpl-3.0_16.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ is_license_notice: yes
---

* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License version 3 as
* it under the terms of the {{GNU Lesser General Public License version 3}} as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License version 3
* You should have received a copy of the {{GNU Lesser General Public License version 3}}
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
18 changes: 18 additions & 0 deletions tests/licensedcode/data/datadriven/lic4/4995-lgpl-2.0-plus-not-lgpl-3.0.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/**
* Copyright (C) 2012 Trever Fischer <tdfischer@fedoraproject.org>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
*/
10 changes: 10 additions & 0 deletions tests/licensedcode/data/datadriven/lic4/4995-lgpl-2.0-plus-not-lgpl-3.0.cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
license_expressions:
- lgpl-2.0-plus
- lgpl-2.0-plus
notes: |
LGPL "either version 2 of the License, or (at your option) any later
version" notice header from KDE libqzeitgeist src/logbrowser.cpp as
reported in https://github.com/aboutcode-org/scancode-toolkit/issues/4995
This notice never mentions version 3 and must not be detected as lgpl-3.0:
it used to match lgpl-3.0_16.RULE by a partial sequence match before that
rule got required phrases.
Loading