Skip to content

I2SIn streaming protocol changes#11068

Merged
tannewt merged 1 commit into
adafruit:mainfrom
FoamyGuy:audioi2sin_streaming_protocol
Jun 25, 2026
Merged

I2SIn streaming protocol changes#11068
tannewt merged 1 commit into
adafruit:mainfrom
FoamyGuy:audioi2sin_streaming_protocol

Conversation

@FoamyGuy

Copy link
Copy Markdown
Collaborator

Implements changes from feedback in #11064

  • Remove wrapper functions for get and reset buffer
  • Remove output_bit_depth property in favor of bits_per_sample that comes from the streaming interface
  • Cleaned up docstrings, correct references to order and remove reference to internal var name.

The change to use self->base.sample_rate instead of self->sample_rate could work in the espressif port I think, but in raspberrypi port those values end up differing slightly. See comment and code link in 11064 for details. For now I've just left them alone for both so that the classes in the different ports are the same. I'm open to ideas on how best to handle it.

@tannewt tannewt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@tannewt tannewt merged commit dd5a51c into adafruit:main Jun 25, 2026
410 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants