Fix releaseCheck.sh script post JMODs in JDK 24+#193
Merged
jerboaa merged 1 commit intoadoptium:masterfrom May 8, 2025
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
Contributor
Author
|
Related: adoptium/adoptium-support#1271 |
Contributor
Author
|
/thaw |
github-actions
Bot
dismissed
their stale review
Pull Request unblocked - code freeze is over.
karianna
approved these changes
Apr 30, 2025
1 task
Contributor
Author
|
@sxa Could you please help review this? |
jerboaa
changed the title
sxa
approved these changes
May 8, 2025
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per added artefact we need to account for
4extra items (base,*.json,*.sig, and*.sha256.txt) in thereleaseCheck.shscript. While at it, I've broken the long lines into two and broken theEXPECTEDadjustment into separate lines.Thoughts?