Implementation for the worker API - #1121
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit intoAug 25, 2026
Merged
Conversation
sfunkenhauser
marked this pull request as ready for review
August 21, 2026 17:51
sfunkenhauser
commented
Aug 21, 2026
| return errs | ||
| } | ||
|
|
||
| func (s *Service) DrainWorker(ctx context.Context, req *ateapipb.DrainWorkerRequest) (*ateapipb.Worker, error) { |
Collaborator
Author
There was a problem hiding this comment.
Right now DrainWorker has unnecessary preconditions, as these are required at the storage layer. I'm not sure this PR needs to be blocked by this, but we should discuss if the storage layer is the correct place to enforce preconditions.
sfunkenhauser
force-pushed
the
worker_api_impl
branch
3 times, most recently
from
August 24, 2026 23:52
a6fa09d to
ce0fba8
Compare
sfunkenhauser
force-pushed
the
worker_api_impl
branch
from
August 25, 2026 13:12
ce0fba8 to
f09e35f
Compare
| @@ -2454,8 +2454,10 @@ func TestResumeActor_CrashesIfAssignedWorkerIsDraining(t *testing.T) { | |||
| if err != nil { | |||
Collaborator
There was a problem hiding this comment.
Let's do in follow up PR, but can we add tests for the Worker methods to functionaltest/worker_test.go?
Julian Gutierrez Oschmann (juli4n)
approved these changes
Aug 25, 2026
Julian Gutierrez Oschmann (juli4n)
merged commit Aug 25, 2026
9b08310
into
agent-substrate:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #730