Rename controlapi.Service -> RpcService - #1148
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit intoAug 24, 2026
Merged
Conversation
Collaborator
I prefer RPCService, otherwise some golangci-lint configs will complain about it (although there are lots of |
Luiz Oliveira (laoj2)
previously approved these changes
Aug 24, 2026
Julian Gutierrez Oschmann (juli4n)
previously approved these changes
Aug 24, 2026
Collaborator
|
It looks like a flake. Re-running the failed ones. |
Tim Hockin (thockin)
dismissed stale reviews from Julian Gutierrez Oschmann (juli4n) and Luiz Oliveira (laoj2)
via
August 24, 2026 18:55
34a1527
Tim Hockin (thockin)
force-pushed
the
rename_controlapi_service
branch
from
August 24, 2026 18:55
3a44d08 to
34a1527
Compare
Collaborator
Author
|
Pushed with RpcService -> RPCService |
Having been reading this code for a while, and in light of changes we want to make, I think something like this will help clarify.
Tim Hockin (thockin)
force-pushed
the
rename_controlapi_service
branch
from
August 24, 2026 20:51
34a1527 to
9811996
Compare
Collaborator
Author
|
rebased |
Collaborator
Author
|
w00t it passed CI |
Julian Gutierrez Oschmann (juli4n)
merged commit Aug 24, 2026
87361ea
into
agent-substrate:main
12 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having been reading this code for a while, and in light of changes we want to make, I think something like this will help clarify.
I am not particularly attached to the name or style
RpcService- it's not usual Go convention but it is protobuf style. If anyone feels strongly it could beRPCServiceorControlServiceor something else.Julian Gutierrez Oschmann (@juli4n) Luiz Oliveira (@laoj2)