fix: fix 'occured' -> 'occurred' typos in error messages#988
fix: fix 'occured' -> 'occurred' typos in error messages#988Sai Asish Y (SAY-5) wants to merge 2 commits intoairbytehq:mainfrom
Conversation
…extractor Multiple error messages read 'occured'. Fixed to 'occurred'. String-literal-only change. Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
📝 WalkthroughWalkthroughTwo files updated to correct the spelling of "occurred" in error messages, fixing the typo "occured" in exception text raised during file extraction and error collection processes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.py (1)
116-116: Great catch on the typo fixes! 👍The corrections from "occured" to "occurred" in both error messages look good to me. Since we ran the verification, we found one more instance of this same typo elsewhere in the codebase:
unit_tests/sources/file_based/stream/test_default_file_based_stream.py: "Some errors occured while reading from the source."Would you be interested in fixing that one too while you're at it, or would you rather leave it as a follow-up task?
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.py` at line 116, Update the remaining typo instance by changing "occured" to "occurred" in the unit test message string; specifically edit the assertion/message in test_default_file_based_stream.py where the text reads "Some errors occured while reading from the source." so the test and any matching expectations use the correct spelling "occurred".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.py`:
- Line 116: Update the remaining typo instance by changing "occured" to
"occurred" in the unit test message string; specifically edit the
assertion/message in test_default_file_based_stream.py where the text reads
"Some errors occured while reading from the source." so the test and any
matching expectations use the correct spelling "occurred".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 06937572-09d3-4ec2-a059-cc26e304073c
📒 Files selected for processing (2)
airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.pyairbyte_cdk/sources/file_based/exceptions.py
Multiple error messages contained
occured:airbyte_cdk/sources/file_based/exceptions.pyline 58airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.pylines 116, 150Fixed to
occurred. String-literal-only change.Summary by CodeRabbit