Skip to content

fix: fix 'occured' -> 'occurred' typos in error messages#988

Open
Sai Asish Y (SAY-5) wants to merge 2 commits intoairbytehq:mainfrom
SAY-5:fix-occured-typos
Open

fix: fix 'occured' -> 'occurred' typos in error messages#988
Sai Asish Y (SAY-5) wants to merge 2 commits intoairbytehq:mainfrom
SAY-5:fix-occured-typos

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 Sai Asish Y (SAY-5) commented Apr 16, 2026

Multiple error messages contained occured:

  • airbyte_cdk/sources/file_based/exceptions.py line 58
  • airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.py lines 116, 150

Fixed to occurred. String-literal-only change.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected spelling in error messages for improved clarity.

…extractor

Multiple error messages read 'occured'. Fixed to 'occurred'. String-literal-only change.

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
@github-actions github-actions bot added the community PRs from community contributors label Apr 16, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 16, 2026

📝 Walkthrough

Walkthrough

Two files updated to correct the spelling of "occurred" in error messages, fixing the typo "occured" in exception text raised during file extraction and error collection processes.

Changes

Cohort / File(s) Summary
Typo Corrections in Error Messages
airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.py, airbyte_cdk/sources/file_based/exceptions.py
Fixed spelling of "occurred" (was "occured") in error messages across two files. Changes are cosmetic and affect exception message text only, with no impact on exception handling behavior or control flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: correcting 'occured' to 'occurred' typos in error messages across two files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.py (1)

116-116: Great catch on the typo fixes! 👍

The corrections from "occured" to "occurred" in both error messages look good to me. Since we ran the verification, we found one more instance of this same typo elsewhere in the codebase:

  • unit_tests/sources/file_based/stream/test_default_file_based_stream.py: "Some errors occured while reading from the source."

Would you be interested in fixing that one too while you're at it, or would you rather leave it as a follow-up task?

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.py` at
line 116, Update the remaining typo instance by changing "occured" to "occurred"
in the unit test message string; specifically edit the assertion/message in
test_default_file_based_stream.py where the text reads "Some errors occured
while reading from the source." so the test and any matching expectations use
the correct spelling "occurred".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.py`:
- Line 116: Update the remaining typo instance by changing "occured" to
"occurred" in the unit test message string; specifically edit the
assertion/message in test_default_file_based_stream.py where the text reads
"Some errors occured while reading from the source." so the test and any
matching expectations use the correct spelling "occurred".

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 06937572-09d3-4ec2-a059-cc26e304073c

📥 Commits

Reviewing files that changed from the base of the PR and between 1256a1f and 0370c12.

📒 Files selected for processing (2)
  • airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.py
  • airbyte_cdk/sources/file_based/exceptions.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community PRs from community contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant