chore: remove rhiza template test suite and release/sync tooling - #79
chore: remove rhiza template test suite and release/sync tooling#79tschm wants to merge 1 commit into
Conversation
Drops the vendored rhiza template self-tests (.rhiza/tests/, minus the retained conftest.py and README.md), the requirements/ pins, the pip-audit and suppression-audit utilities, the releasing.mk make fragment, the .rhiza-version marker, and the rhiza_sync.yml workflow. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Not ready to approve
Several remaining make targets/config still reference deleted Rhiza scripts/tests/version markers, which will cause broken targets and likely version drift unless callers and the template lock are updated.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Removes Rhiza template-managed self-test suite and related tooling from the repository, including sync/release support files and pinned requirements lists.
Changes:
- Deletes
.rhiza/tests/**template self-tests (api/integration/structure/sync/stress/shell) and related utilities. - Removes
.rhiza/requirements/**pin files and.rhiza/utils/**audit helper scripts. - Drops Rhiza template sync workflow, Rhiza version marker, and Make release targets (
releasing.mk).
File summaries
| File | Description |
|---|---|
| .rhiza/utils/suppression_audit.py | Removed suppression-audit helper script. |
| .rhiza/utils/pip_audit_policy.py | Removed pip-audit policy helper script. |
| .rhiza/tests/utils/test_git_repo_fixture.py | Removed template test for git_repo fixture. |
| .rhiza/tests/test_utils.py | Removed shared test utilities used by template tests. |
| .rhiza/tests/sync/test_readme_validation.py | Removed README example validation tests. |
| .rhiza/tests/sync/test_docstrings.py | Removed doctest-based docstring tests. |
| .rhiza/tests/sync/conftest.py | Removed sync-test environment fixture setup. |
| .rhiza/tests/structure/test_requirements.py | Removed requirements folder structure tests. |
| .rhiza/tests/structure/test_pyproject.py | Removed pyproject structure/version consistency tests. |
| .rhiza/tests/structure/test_project_layout.py | Removed template project layout/root fixture tests. |
| .rhiza/tests/stress/README.md | Removed template stress-test documentation. |
| .rhiza/tests/stress/conftest.py | Removed stress-test pytest options/fixtures. |
| .rhiza/tests/stress/init.py | Removed stress-test package marker/docstring. |
| .rhiza/tests/shell/test_scripts.sh | Removed shell-script test harness. |
| .rhiza/tests/integration/test_virtual_env_unexport.py | Removed integration test for Make env behavior. |
| .rhiza/tests/integration/test_test_mk.py | Removed integration test covering test.mk behavior. |
| .rhiza/tests/integration/test_docs_targets.py | Removed integration tests for docs/book targets. |
| .rhiza/tests/integration/test_book_targets.py | Removed integration tests for book target resilience. |
| .rhiza/tests/api/test_makefile_targets.py | Removed API tests validating Makefile targets/help output. |
| .rhiza/tests/api/test_makefile_api.py | Removed API tests for Makefile wrapper/override patterns. |
| .rhiza/tests/api/test_make_variable_overrides.py | Removed tests for Make variable override behavior. |
| .rhiza/tests/api/test_github_targets.py | Removed tests for GitHub-related make targets. |
| .rhiza/tests/api/conftest.py | Removed API test fixtures and temp Makefile setup. |
| .rhiza/requirements/tools.txt | Removed tools requirements pins list. |
| .rhiza/requirements/tests.txt | Removed test requirements pins list. |
| .rhiza/requirements/README.md | Removed requirements folder documentation. |
| .rhiza/requirements/marimo.txt | Removed marimo requirements pins list. |
| .rhiza/requirements/docs.txt | Removed docs requirements pins list. |
| .rhiza/make.d/releasing.mk | Removed make targets for bump/release/publish/release-status. |
| .rhiza/.rhiza-version | Removed Rhiza version marker file. |
| .github/workflows/rhiza_sync.yml | Removed scheduled/triggered Rhiza template-sync workflow. |
Review details
Comments suppressed due to low confidence (6)
.rhiza/.rhiza-version:1
.rhiza/rhiza.mkreadsRHIZA_VERSIONfrom this file (.rhiza/rhiza.mk:55-56) to decide whichrhiza==...version to run formake sync/validate. Deleting it forces the fallback version (0.10.2in rhiza.mk), which is likely inconsistent with the template lock ref (.rhiza/template.lock:4isv0.18.8) and can cause sync/validate behavior drift.
.rhiza/utils/pip_audit_policy.py:1- This file is deleted, but
make securitystill executes it via.rhiza/make.d/test.mk:71(${UV_BIN} run python .rhiza/utils/pip_audit_policy.py ...). Running the security target will now fail with a missing-file error; either remove/adjust thesecuritytarget or replace this script with an inlineuvx pip-audit ...invocation.
.rhiza/utils/suppression_audit.py:1 - This file is deleted, but
make suppression-auditstill executes it via.rhiza/make.d/quality.mk:47(${UV_BIN} run python .rhiza/utils/suppression_audit.py). That target will now fail with a missing-file error, so the Makefile should be updated to remove/replace the target. Also, this path remains listed in.rhiza/template.lock:77, so the next template sync is likely to restore it unless the lock is updated too.
.rhiza/tests/structure/test_pyproject.py:1 - This test file is deleted, but the
test-pyprojecttarget still runs it (.rhiza/make.d/test.mk:165-166). Invokingmake test-pyprojectwill now fail; either remove that target or point it at a replacement test location.
.rhiza/requirements/docs.txt:1 - With this requirements file removed, the
docs-coveragetarget in.rhiza/make.d/test.mk:100still runsuv run interrogate ...(without--with interrogate). Unless interrogate is added to the uv environment viapyproject.tomlor the Makefile is changed to useuvx/uv run --with,make docs-coveragewill fail due to a missing executable/module.
.rhiza/requirements/tools.txt:1 - With this requirements file removed, the
typechecktarget in.rhiza/make.d/test.mk:58still runsuv run ty check ...(without--with ty). Unlesstyis added to the uv environment viapyproject.tomlor the Makefile is changed to useuvx/uv run --with,make typecheckwill fail due to a missing executable/module.
- Files reviewed: 31/31 changed files
- Comments generated: 0
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
|
Closing as redundant and mis-targeted. These 31 deletions were opened against The identical 31 deletions now live in tschm#25 alongside the v1.2.5 sync that justifies them, where all CI checks pass. Deleting them here instead would remove files the current template still ships and leave No work is lost — everything here is carried by tschm#25. |
Summary
Removes 31 rhiza template-managed files (3,333 deletions, no additions):
.rhiza/tests/— the vendored template self-test suite (api, integration, structure, sync, stress, shell).conftest.pyandREADME.mdare retained..rhiza/requirements/— docs/marimo/tests/tools pin files and their README..rhiza/utils/—pip_audit_policy.pyandsuppression_audit.py..rhiza/make.d/releasing.mk— thebump/release/publish/release-statustargets and thepre-*/post-*hooks..rhiza/.rhiza-version— the version marker..github/workflows/rhiza_sync.yml— the automated template-sync workflow.Consequences worth noting
make bump,make release,make publish, andmake release-statusno longer exist locally.rhiza_release.ymlis tag-triggered, so release CI itself is unaffected — but tags now have to be pushed by hand (or via/rhiza:release).make test-pyprojectin.rhiza/make.d/test.mk:166still points at the now-deleted.rhiza/tests/structure/test_pyproject.pyand will fail. No workflow invokes it./rhiza:updatemust be run manually..rhiza/template.lock, so the next sync will restore them unless the lock is updated too.The
-include .rhiza/make.d/*.mkglob inrhiza.mkis a wildcard, so droppingreleasing.mkdoes not break the include.🤖 Generated with Claude Code