add BoringSSL support - #7
Conversation
Techatrix
left a comment
There was a problem hiding this comment.
I just merged a PR that updated googletest to Zig 0.16.0 so this should be unblocked.
I'd prefer to keep the dependencies within the allyourcodebase organization if possible. Which would allow me and other members to more easily contribute if needed. Would you be open to join allyourcodebase and then contribute your boringssl port to it? More information on how to join can be found here:
That makes sense! I'll update boringssl to use the merged googletest and ping kristoff about joining the org and moving the project over. |
|
I moved boringssl to the allyourcodebase org. |
|
I pushed 78d0fc1 to match upstream with how it represents the The usage of akunaakwei/zig-patch is problematic because it uses a custom build step. This will be removed in Zig 0.17.0 in favor of defining a std.Build.Step.Run step. It also appears to fail to properly cache its output. This PR also needs a rebase. I'd recommend squashing the commits before doing so. |
I see. I've setup a PR to address your concern regarding defining custom steps. This change also fixes the caching behaviour. I'll rebase + update + check functionality again once we have that change. |
157a531 to
7f94239
Compare
7f94239 to
bc02ae4
Compare
|
Boringssl now uses the latest version of I've squashed the commits here and rebased to master. I also tested that the changes still work with olksdr/sentry-native#2. Let me know if there is something else remaining you'd like me to take a look at. |
Techatrix
left a comment
There was a problem hiding this comment.
Thank you for your patience to get through this long review process. Let's merge this!
This PR integrates boringssl.
I've been using a variation of these changes for a while now.
I would like to upstream these changes to avoid relying on my fork in other projects.
Compile as
And run
Output
Ideally we wait until the following PRs are merged to avoid relying on my forks in the
boringsslrepository.