This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(uiSelectMultiple): check if control key is pressed before calling KEY.isHorizontalMovement#2029
Open
jbpitts wants to merge 12 commits intoangular-ui:masterfrom
Open
fix(uiSelectMultiple): check if control key is pressed before calling KEY.isHorizontalMovement#2029jbpitts wants to merge 12 commits intoangular-ui:masterfrom
jbpitts wants to merge 12 commits intoangular-ui:masterfrom
Conversation
… KEY.isHorizontalMovement, breaks opt+cmd+right or left on some browsers
… width, otherwise control can cause overflow
…ng input width, otherwise control can cause overflow" This reverts commit d28ba36.
…g vertical resize event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(uiSelectMultiple): check if control key is pressed before calling KEY.isHorizontalMovement, breaks opt+cmd+right or left on some browsers, for instance Opera on XOS
change consistent with use of KEY.isControl(e) for other keydown events