Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

multiple select placeholder late bind fix#2042

Open
SarperMUTLUBAY wants to merge 5 commits intoangular-ui:masterfrom
SarperMUTLUBAY:master
Open

multiple select placeholder late bind fix#2042
SarperMUTLUBAY wants to merge 5 commits intoangular-ui:masterfrom
SarperMUTLUBAY:master

Conversation

@SarperMUTLUBAY
Copy link
Copy Markdown

before fix

ui-select-before

after fix

ui-select-after

@Jefiozie Jefiozie self-requested a review August 28, 2017 06:25
Copy link
Copy Markdown
Contributor

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clean up the dist folder?

Thanks

@SarperMUTLUBAY
Copy link
Copy Markdown
Author

dist folder cleaned.

@Jefiozie
Copy link
Copy Markdown
Contributor

Jefiozie commented Oct 8, 2017

Can you revert your past commit? Please revert back the dist folder before the changes, when releasing a new version it will be updated.

Sorry for the extra work maybe is was not clear enough.

@SarperMUTLUBAY
Copy link
Copy Markdown
Author

clean and completed.

@Jefiozie
Copy link
Copy Markdown
Contributor

Jefiozie commented Oct 15, 2017

Hi @SarperMUTLUBAY could you merge the master in your branch and see if the issue with the build is fixed?
Thanks

@SarperMUTLUBAY
Copy link
Copy Markdown
Author

hi @Jefiozie my repository now synced origin repository and build succedded.

@Jefiozie
Copy link
Copy Markdown
Contributor

Thanks, had a look again on your change. The only thing you changed is the css off the searchInput"right? Is this making the binding do strange stuff?

@SarperMUTLUBAY
Copy link
Copy Markdown
Author

@Jefiozie yes, it causes the search input to load late bindings.

@Jefiozie
Copy link
Copy Markdown
Contributor

@SarperMUTLUBAY can you share a plunker with a non working example? So I can have a look and see the problem and the fix you applied?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants