docs: mention Vitest instead of Karma in README template of schematic… - #33573
Open
guisalmeida wants to merge 1 commit into
Open
docs: mention Vitest instead of Karma in README template of schematic…#33573guisalmeida wants to merge 1 commit into
guisalmeida wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the library README template to reference the Vitest test runner instead of Karma. The review feedback correctly points out that since Karma is still supported as a fallback, hardcoding Vitest will lead to incorrect documentation. It is recommended to dynamically display the test runner name based on the template context.
alan-agius4
added
the
target: patch
alan-agius4
approved these changes
Aug 18, 2026
alan-agius4
left a comment
alan-agius4
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfils the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Since version Angular 21, Vitest is the default test runner.
Issue Number: N/A
What is the new behavior?
Mention Vitest instead of Karma.
Does this PR introduce a breaking change?
Other information
Found a similar change in #31916, but it seems this part in the schematic/library files was forgotten to change as well.