Skip to content

refactor(multiple): Clean up afterRenderEffect usage across angular aria#33054

Draft
adolgachev wants to merge 8 commits intoangular:mainfrom
adolgachev:aria-effects
Draft

refactor(multiple): Clean up afterRenderEffect usage across angular aria#33054
adolgachev wants to merge 8 commits intoangular:mainfrom
adolgachev:aria-effects

Conversation

@adolgachev
Copy link
Copy Markdown
Contributor

@adolgachev adolgachev commented Apr 8, 2026

Across angular-aria afterRenderEffect was being used as a general-purpose synching hook. Also, a phase was not specified so it always was defaulting to the mixedReadWrite phase which is not as performant and unnecessary in all the cases.

This PR cleans up the usage by:

  • Swapping to effect when only internal state is being updated
  • Using write mode whenever necessary to write to the DOM (primarily focus updates)
  • Using read mode when not necessary to write but need to update state post render
  • Other as appropriate clean up to use computed instead of an effect

See https://angular.dev/guide/signals/effect#render-phases for background.

@adolgachev adolgachev changed the title Aria effects refactor(multiple): Clean up afterRenderEffect usage across angular aria Apr 8, 2026
@adolgachev adolgachev force-pushed the aria-effects branch 5 times, most recently from 997e387 to 1f804a2 Compare April 13, 2026 01:14
@adolgachev adolgachev added dev-app preview When applied, previews of the dev-app are deployed to Firebase action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 13, 2026
@github-actions
Copy link
Copy Markdown

Deployed dev-app for 8b8a855 to: https://ng-dev-previews-comp--pr-angular-components-33054-dev-v6daybga.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: aria/combobox area: aria/grid area: aria/listbox area: aria/menu area: aria/tree dev-app preview When applied, previews of the dev-app are deployed to Firebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant