Repository navigation
fix(aria/menu): accept a bare disabled attribute on MenuItem - #33965
Open
DuncanFaulkner wants to merge 1 commit into
Open
DuncanFaulkner wants to merge 1 commit into
DuncanFaulkner wants to merge 1 commit into
Conversation
MenuItem.disabled was declared as input<boolean>(false), so <div ngMenuItem disabled> failed strict template type-checking and was not disabled in JIT. Use booleanAttribute, like the disabled inputs on the other aria directives. Fixes angular#33964
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MenuItem.disabledwas declared asinput<boolean>(false), so<div ngMenuItem disabled>failed strict template type-checking (and was not disabled in JIT). It now usesbooleanAttribute, like thedisabledinputs on the other aria directives.Adds a test that a bare
disabledattribute setsaria-disabled="true".Fixes #33964