This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
datepicker: invalid value on first load from moment #12118
Description
Bug Report
Demo URL (required)*: https://datepicker-invalid-value-on-first-load-from-string-12075-pskwl4.stackblitz.io
Detailed Reproduction Steps
- Start date as moment object
List the affected versions of AngularJS, Material, OS, and browsers
- AngularJS: 1.8.2
- AngularJS Material: 1.2.3
- OS: All
- Browsers: All
- Screen Readers:
Add anything else we should know
This was just fixed for string being the default last version.
I added the below to that ticket, but I added it too late. I should have just opened a new ticket. Sorry about that.
When DatePickerCtrl.prototype.updateErrorState is called with a moment date
if (this.dateUtil.isValidDate(date)) { is false
So this.ngModelCtrl.$setValidity('valid', date == null); runs and the ngModel ctrl valid key is set to false.
Activity
[-]datepicker: invalid value on first load from string[/-][+]datepicker: invalid value on first load from moment[/+]Splaktar commentedon Nov 18, 2021
Thank you for opening this issue. Sorry that I didn't notice your comment in #12075 and address that as well in PR #12115.
matrium0 commentedon Jan 2, 2022
@Splaktar it seems this bug is also present if you use the Luxon Adapter instead of the Moment Adapter
Splaktar commentedon Jan 2, 2022
@matrium0 AngularJS Material doesn't have an official Luxon adapter. Which are you using?
matrium0 commentedon Jan 3, 2022
Ah sorry, I noticed a similar bug in MatLuxonDateModule (installed via @angular/material-luxon-adapter) for Angular not AngularJS.
My bad! (still I choose to blame it a tiny little bit on the choice to "keep the name" Angular :D ). Thanks for your quick response!