datepicker: migrate to use mdPanel container #9564

Activity

1. ErinCoughlan

   added

   - Use $mdPanel

   on Sep 9, 2016
2. ErinCoughlan

   assigned

   crisbeto

   on Sep 9, 2016
3. ThomasBurleson

   modified the milestone: - Backlog on Sep 12, 2016
4. crisbeto

   added

   in progressMainly for in progress PRs, but may be used for issues that require multiple PRsMainly for in progress PRs, but may be used for issues that require multiple PRs

   on Sep 13, 2016
5. crisbeto commented on Sep 13, 2016

   

   crisbeto

   on Sep 13, 2016

   Last edited by crisbeto

   Member

   More actions

   @ErinCoughlan I got the datepicker positioning working without too much hassle, however I ran in a couple of issues that could be solved in the panel:

   1. The withOffsetX and withOffsetY only accept string offsets and didn't work (nor complain) at all when supplied a number. I think that we could safely assume that if it's a number, it's in pixels and we can append the unit automatically.
   2. Currently the offsets need to be known ahead of time, however it would be useful if we could pass in a function that determines the offset later. The API could look like this:

   mdPanelPosition.withOffsetX(function(dimensionOfTargetElement) {
     return whateverOffsetShouldBeSet; // this can be based on the passed in dimensions.
   });

   Point 2 could technically be done in the open callback, however in slower browsers (e.g. IE and Edge) the adjustment is pretty visible.
6. ErinCoughlan commented on Sep 14, 2016

   

   ErinCoughlan

   on Sep 14, 2016

   ContributorAuthor

   More actions

   @crisbeto I like the idea of allowing a function as well as assuming the 'px' if supplied a number. I think that can help prevent some user errors. Please file separate Issues for each of those bugs and we can tackle them to improve the datepicker.
7. ThomasBurleson

   changed the title [-]mdPanel: Rewrite mdDatepicker to use the panel.[/-] [+]datePicker: use mdPanel container[/+] on Sep 15, 2016
8. crisbeto commented on Sep 18, 2016

   

   crisbeto

   on Sep 18, 2016

   Last edited by crisbeto

   Member

   More actions

   @ErinCoughlan another one I ran into: at the moment, you can set the panel to close via clicking outside or pressing escape, however the datepicker also has the case where it closes the calendar if the user tabs away. Do you think it makes sense to have the "close on" keys configurable through $mdPanel or just continue handling it within the calendar?
9. ErinCoughlan commented on Sep 18, 2016

   

   ErinCoughlan

   on Sep 18, 2016

   ContributorAuthor

   More actions

   @crisbeto I think tab makes a lot of sense. That's also used in popovers, basically if you tab past the end, focus leaves instead of being trapped.

   I'm wondering two things in terms of use and API:

   1. Should tab outside panel always close the panel if trapFocus is false? This is more from an accessibility point of view and perhaps it doesn't make sense to be a requirement at the panel level, but I think it's usually the case.
   2. What other keys can/should close the panel? The only others I can think of it ctrl + ? For a help panel, but I'm not sure that's a common case. I ask because I'm trying to figure out how flexible this needs to be.
10. crisbeto commented on Sep 18, 2016

    

    crisbeto

    on Sep 18, 2016

    Member

    More actions

    1. This might be tricky to get right on something as generic as the panel. That's why I'm on the fence on whether it makes sense.
    2. I can't think of any off the top of my head, apart from escape and tab.
11. crisbeto

    added a commit that references this issue on Sep 19, 2016

    feat(datepicker): migrate to mdPanel

    ...

    This issue will close once commit 102f0cf is merged into the 'master' branch.

    102f0cf
12. crisbeto

    added

    has: Pull RequestA PR has been created to address this issueA PR has been created to address this issue

    on Sep 19, 2016
13. crisbeto

    added 2 commits that reference this issue on Sep 19, 2016

    feat(datepicker): migrate to mdPanel

    ...

    This issue will close once commit 1bf91d5 is merged into the 'master' branch.

    1bf91d5

    feat(datepicker): migrate to mdPanel

    ...

    This issue will close once commit bf7a1b7 is merged into the 'master' branch.

    bf7a1b7
14. 11 remaining items

    Load more
15. crisbeto

    added 2 commits that reference this issue on Oct 26, 2016

    feat(datepicker): migrate to mdPanel

    ...

    This issue will close once commit d998760 is merged into the 'master' branch.

    d998760

    feat(datepicker): migrate to mdPanel

    ...

    This issue will close once commit 91e5926 is merged into the 'master' branch.

    91e5926
16. Splaktar

    modified the milestones: - Backlog, 1.2.0 on Feb 7, 2018
17. Splaktar

    added

    P2: requiredIssues that must be fixed.Issues that must be fixed.

    a11yThis issue is related to accessibilityThis issue is related to accessibility

    on Feb 7, 2018
18. Splaktar

    added

    g3: reportedThe issue was reported by an internal or external product team.The issue was reported by an internal or external product team.

    on Jan 16, 2019
19. Splaktar

    changed the title [-]datePicker: use mdPanel container[/-] [+]datepicker: migrate to use mdPanel container[/+] on Feb 12, 2019
20. Splaktar

    added

    BlockedProgress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback.Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback.

    on Feb 12, 2019
21. Splaktar

    unassigned

    crisbeto

    on Jun 6, 2019
22. Splaktar

    assigned

    Splaktar

    and

    crisbeto

    on May 15, 2020
23. Splaktar

    removed

    - use $mdPanel

    on May 15, 2020
24. Splaktar

    modified the milestones: 1.2.0, 1.3.0 on Jul 30, 2020