Skip to content

Generate GetDefaultMappings as an array instead of an iterator #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmilnthorp wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Generate GetDefaultMappings as an array instead of an iterator #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2709f86
Generate GetDefaultMappings as an array instead of an iterator
tmilnthorp Oct 6, 2026
6927559
Regenerate code
tmilnthorp Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions CodeGen/Generators/UnitsNetGen/QuantityGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,9 @@ public sealed class {quantityInfoClassName}: QuantityInfo<{_quantity.Name}, {_un
/// </summary>
/// <returns>An <see cref=""IEnumerable{{T}}""/> of <see cref=""UnitDefinition{{{_unitEnumName}}}""/> representing the default unit mappings for {_quantity.Name}.</returns>
public static IEnumerable<UnitDefinition<{_unitEnumName}>> GetDefaultMappings()
{{");
{{
return new UnitDefinition<{_unitEnumName}>[]
{{");

foreach (Unit unit in _quantity.Units)
{
Expand Down Expand Up @@ -259,7 +261,7 @@ public sealed class {quantityInfoClassName}: QuantityInfo<{_quantity.Name}, {_un
if (unit.SingularName == _quantity.BaseUnit)
{
Writer.WL($@"
yield return new ({_unitEnumName}.{unit.SingularName}, ""{unit.SingularName}"", ""{unit.PluralName}"", {baseUnitsFormat});");
new ({_unitEnumName}.{unit.SingularName}, ""{unit.SingularName}"", ""{unit.PluralName}"", {baseUnitsFormat}),");
}
else
{
Expand All @@ -268,22 +270,23 @@ public sealed class {quantityInfoClassName}: QuantityInfo<{_quantity.Name}, {_un
if (expressionFromBaseToUnit.Terms.Count == 1 && expressionFromBaseToUnit.Degree == Fraction.One)
{
Writer.WL($@"
yield return new ({_unitEnumName}.{unit.SingularName}, ""{unit.SingularName}"", ""{unit.PluralName}"", {baseUnitsFormat},
{expressionFromBaseToUnit.GetConversionExpressionFormat()}
);");
new ({_unitEnumName}.{unit.SingularName}, ""{unit.SingularName}"", ""{unit.PluralName}"", {baseUnitsFormat},
{expressionFromBaseToUnit.GetConversionExpressionFormat()}
),");
}
else
{
Writer.WL($@"
yield return new ({_unitEnumName}.{unit.SingularName}, ""{unit.SingularName}"", ""{unit.PluralName}"", {baseUnitsFormat},
{expressionFromBaseToUnit.GetConversionExpressionFormat()},
{unit.GetUnitToBaseConversionExpressionFormat()}
);");
new ({_unitEnumName}.{unit.SingularName}, ""{unit.SingularName}"", ""{unit.PluralName}"", {baseUnitsFormat},
{expressionFromBaseToUnit.GetConversionExpressionFormat()},
{unit.GetUnitToBaseConversionExpressionFormat()}
),");
}
}
}

Writer.WL($@"
}};
}}
}}
");
Expand Down
101 changes: 52 additions & 49 deletions UnitsNet/GeneratedCode/Quantities/AbsorbedDoseOfIonizingRadiation.g.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

83 changes: 43 additions & 40 deletions UnitsNet/GeneratedCode/Quantities/Acceleration.g.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading