fix(opencode): centralize unsecured server warning#22123
Open
shafdev wants to merge 2 commits intoanomalyco:devfrom
Open
fix(opencode): centralize unsecured server warning#22123shafdev wants to merge 2 commits intoanomalyco:devfrom
shafdev wants to merge 2 commits intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22122
Type of change
What does this PR do?
This fixes inconsistent unsecured-server warning behavior when
OPENCODE_SERVER_PASSWORDis unset.Before this change, warning output was handled in
serveandwebcommand handlers, so other startup paths (likeacp) could start an unsecured server without showing the warning.I moved the warning to the shared server startup path (
Server.listen) and removed duplicated warning logic fromserveandweb.This makes behavior consistent for all commands that start the server.
Files changed:
packages/opencode/src/server/server.tspackages/opencode/src/cli/cmd/serve.tspackages/opencode/src/cli/cmd/web.tsHow did you verify your code works?
bun run --cwd packages/opencode typecheckbun run --cwd packages/opencode testunset OPENCODE_SERVER_PASSWORDbun dev serve-> warning shownbun dev acp-> warning shownScreenshots / recordings
N/A (non-UI change)
Checklist