feat: register themes in $CONFIG/opencode/desktop-themes/#31952
Open
adhi-thirumala wants to merge 1 commit into
Open
feat: register themes in $CONFIG/opencode/desktop-themes/#31952adhi-thirumala wants to merge 1 commit into
adhi-thirumala wants to merge 1 commit into
Conversation
adhi-thirumala
force-pushed
the
desktop-theme
branch
from
39ad728 to
23f419c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31948
Type of change
What does this PR do?
Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.
Functionality for loading themes in as JSON already exists. This automatically does that for themes in
$GLOBAL_CONFIG/desktop-themes/theme.jsonand$PROJECT_CONFIG/desktop-themes/theme.json.How did you verify your code works?
I ran opencode locally and added themes to my local config. They showed up. I also added tests which test this functionality.
Checklist
If you do not follow this template your PR will be automatically rejected.