Repository navigation
Restore namespace aliases after leaving a child element - #144
Merged
zhengchun merged 1 commit intoNov 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A child namespace alias for an existing URI overwrites the parser's URI-to-prefix mapping after that child closes. A later sibling can lose its element namespace and serialize an attribute with an out-of-scope prefix. Keep a per-element undo set and restore aliases on the end token. Tests use encoding/xml as an independent expanded-name oracle, cover namespaced attributes, nested aliases, default-namespace control, and streaming records. This does not attempt to redesign the existing multiple-alias selection within a single scope.
Validation at
247cec34a70e322dc4a2bb8d4aa71def62181357(base9429919ed0a2c62f385c010f24095a149a2d672a):go test ./... -count=1passes.go test -race ./... -count=1passes.git diff --checkpasses.Checks above ran locally on macOS; hosted CI and maintainer review remain separate. Prepared and independently reviewed with Codex assistance.
Related: #79 proposes recovering the lexical element prefix from the raw tag. This change restores the scoped URI-to-prefix metadata itself, including attribute serialization and streaming records; it does not redesign alias selection within a single scope. The existing default-namespace sibling case is retained as a control.